GenoPro Home
GenoPro Home  |  Get Started With My Genealogy Tree  |  Buy  |  Login  |  Privacy  |  Search  |  Site Map
 
Some bugs in the report templates


https://support.genopro.com/Topic7925.aspx
Print Topic | Close Window

By MR - Monday, August 29, 2005
Thanks for the great report !!!

Some new/old bugs:

1. Sometimes only an upper half of the picture of an individual is shown with no scrolling buttons. This happens only in IE, Mozilla works fine. This bug was present in Ron's report and was  fixed by him.

2. Both the husband and wife are alive. Still we have: the had no children. 

3. How do you determine the "order" of the children (oldest, youngest etc)? I assume by the order they were entered into the genomap. If this order is stated incorrectly, what would be the easiest way to correct this in the map?

4. If you want the report to be 150% perfect and if it is not too complicated to correct, please change

      A has a wife named B, and a son and a daughter named C and D

to

      A has a wife named B, a son named C and a daughter named D 

Thanks again for the great job!

By GenoProSupport - Monday, August 29, 2005
Thanks for reporting the problems.  I am aware there are still outstanding issues on the report generator.  What I devoted most of my time was to make sure the architecture of the report engine was sound.

MR (8/29/2005)
1. This bug was present in Ron's report and was fixed by him.

Please send me the fix and I will update it to the master template.

2. Both the husband and wife are alive. Still we have: They had no children.

True.  Being both alive is not enough; they must be still together.  If the couple is separated or divorced, the report generator uses had, otherwise you will read "They have no children yet."

3. How do you determine the "order" of the children (oldest, youngest etc)?

The order of the children is determined by the date of birth, or the child number.  If not, it uses the x-position of each child in the family tree.  There are still outstanding issues when there are multiple children from multiple families/marriages and/or multiple adoption.  Somehow I had to release Beta14, so I postponed this bug.

4. If you want the report to be 150% perfect and if it is not too complicated to correct, please change

      A has a wife named B, and a son and a daughter named C and D
to
      A has a wife named B, a son named C and a daughter named D

I agree what you are proposing is better, however it is much harder to do. I will think of a solution.

By MR - Monday, August 29, 2005
2. Both the husband and wife are alive. Still we have: They had no children.

True.  Being both alive is not enough; they must be still together.  If the couple is separated or divorced, the report generator uses had, otherwise you will read "They have no children yet."

OK. The problem starts from interpreting the blank (default) entry in the relationship field. One would assume that if nothing is written, the default is marriage or similar, but not divorce or separation. Most of my family properties have no marriage indicated, thus giving "they had no children".

By GenoProSupport - Monday, August 29, 2005
MR (8/29/2005)
OK. The problem starts from interpreting the blank (default) entry in the relationship field. One would assume that if nothing is written, the default is marriage or similar, but not divorce or separation. Most of my family properties have no marriage indicated, thus giving "they had no children".

You are right about this.  I made the assumption that if a relationship was blank, they the couple was not living together.  It would probably safer to assume the couple is living together if both are alive.

By MR - Monday, August 29, 2005
Sorry, another one.. "A has a wife named B" even if the relationship indicates 'divorced'
By genome - Tuesday, August 30, 2005
MR (8/29/2005)
1. Sometimes only an upper half of the picture of an individual is shown with no scrolling buttons. This happens only in IE, Mozilla works fine. This bug was present in Ron's report and was fixed by him.

I believe this is the so called IE 'Guillotine' bug.The change that I thought fixed this bug actually didn't! I tried to implement the 'clearfix' class described in http://www.positioniseverything.net/easyclearing.html but I obviously didn't understand the instructions. But an alternative 'cheap and cheerful' solution is to include a 'cleared' element later in the page. So edit the template file individual.htm as follows:

Delete lines 34 & 126 as they do nothing. Insert before line 125 , i.e. before </body>, the line:

<span class='clear'></span>

The reason my code worked and Dan's did not is that my code to write footnotes left an empty <span> element like the above when no footnotes were present. Dan is much more meticulous with his code and of course did not generate superfluous html.

Perhaps someone with a better grasp of html can figure out how the '.cleafix' class should be applied.

By GenoProSupport - Tuesday, August 30, 2005
As strange as it may sound, I am a newbe with both HTML and CSS.  On the other hand, I can improve the report generator to make it easier to generate HTML code.  I already have new ideas for new functions to simplify code generation.

Any suggestion is welcome.  Thanks!

By Barry Graham - Tuesday, August 30, 2005
Report Generator Bugs:-
---------------------------------
In the individual report:-

He had five brothers and five sisters, named....
Then a huge gap until the names.
This seems to be affected by the size and shape of the individuals photo.

He burial was in.....


When the children are displayed beneath the individual their pictures become confused with the text for other children and where there are display controls these are often displayed down in column fashion.
It all looks rather messy.


Please place the Title of the picture beneath the picture and in Regular Text not Italic.
At the moment the Picture Notes position does not relate to the photo.

Could we have an Option to Show all notes when the report is generated.
I'd prefer this to having recipients being forced click on the the Show All Notes or the Notes Icons on every individual in the report.

Could there be an option to use regular text in place of italic within the report - italic is too hard to read with old eyes.

---------------------------
Family report:-

The Family Picture Notes are above the picture and spill down over the photo in column fashion.

There seems to be a lot of inconsistency in how items are displayed throughout the reports.

That's all I've noticed now.

I'm right in the middle of preparing reports on CD for other family members and related descendants.
I've reverted back to the version 13 reports for now.
I'm sure the version 14 report will be quite impressive when the bugs are ironed out.
Keep up the good work.





By GenoProSupport - Tuesday, August 30, 2005
I made the following corrections:

1. If the relationship is not specified, I assume they are together.  You get "He has a wife named ..." rather than "He had a wife named".

2. I fixed the case where multiple spouses could display "has" instead of "had".

3. I corrected the phrase "He burial was".  This was because the text from the enumeration BodyDisposition was not corresponding with the phrase PhBuried.

He had five brothers and five sisters, named.... Then a huge gap until the names.

Can you send me a screen shot?  Perhaps a sample HTML with the problem.

I modified the code so all notes are displayed by default and changed minor things for the picture anotations.  As for the picture title, send me the HTML code of what looks good on your machine. Ron wrote this code and he knows more about this than myself.


I've reverted back to the version 13 reports for now.

Humm... this is not good news for me.  Are the reports from version 13 much better?  I have not intentially modified the report layout for Beta 14.  What I did is move all the text to the language dictionary and use phrases.

I made a silent update of Beta 14 at http://www.genopro.com/beta/ .  If you download & install Beta 14 again, you will get the fixes.

By MR - Tuesday, August 30, 2005
For living couple that has no children you write "they have no children yet". This is not good for people over ... Better would be just to omit "yet". 
By Howard53 - Wednesday, August 31, 2005
This is great progress, but I have found a few problems:
  1. Cause of Death: Because of a combination of the translation of the Cause of Death Tags and the use of 'by' in the Report Generator, odd combinations occur such as 'by due to medical problem' in the report. Suggestion - include the appropriate preposition as part of the Cause of Death Tag translation, eg Stroke T="from a stroke", GivingBirth T="during childbirth", Abortion T="following an abortion", etc. and omit the 'by' in the script.
  2. If an individual has had more than one marriage, the Report reads that the individual has x husband or wives. It would be preferable to say that the individual has been/was married x times.
  3. The marriages can be reported in the wrong order when no date information exists. It is fairly common not to have date information, and could be overcome by the use of a Marriage Number Tag under Family Properties as with Child Number under Individual Properties (this may have been suggested previously).
  4. The Report Generator appears to ignore the information in the Relation Tag under Family Properties, with the result that apparently any sort of relation is reported as a marriage (I haven't tested all the relationships, but certainly engagements and living together do so).
By maru-san - Wednesday, August 31, 2005
Howard53 (8/31/2005)
The Report Generator appears to ignore the information in the Relation Tag under Family Properties, with the result that apparently any sort of relation is reported as a marriage (I haven't tested all the relationships, but certainly engagements and living together do so).


Same over here; my sister is divorced, but shows up as married.
By Randee15 - Wednesday, August 31, 2005
The new report generator looks very promising! BigGrin: This is just a quick note to say that I just tested the new report generator with a few made-up families, and there are two bugs that I've encountered:
  1. Just about every family I tried showed up as "husband"/"wife", even if they're just engaged, dating, or even if the relationship's set to "rape/force relationship"! I think I somehow got "partner" once... but I don't remember what setup I did to get it... Blush
  2. When I input a man who had two partners, one male and one female, it says: "A had a husband,a wife named B [male partner] and C [female partner]."

It's currently a little past six in the morning for me, and I've somehow been up all night. So I need to go grab some sleep, and then maybe I'll do a little more experimenting later.

By GenoProSupport - Wednesday, August 31, 2005
Thanks for your input.  I will look for a solution regarding the other relationships.  I also changed "This marriage was annulled" to "Their marriage was annulled".
By beraha - Wednesday, August 31, 2005
Do you have any solution to the problem where the picture is somtimes cut?
By genome - Wednesday, August 31, 2005
beraha (8/31/2005)
Do you have any solution to the problem where the picture is somtimes cut?

Please see my earlier post in this thread.

By MR - Wednesday, August 31, 2005
Reloaded Beta 14. Just to be sure - picture comments and the buttons for wife/husband of an individual are still given vertically, each line contains just one word or symbol.
By genome - Wednesday, August 31, 2005
Barry Graham (8/30/2005)
Could there be an option to use regular text in place of italic within the report - italic is too hard to read with old eyes.

You can simply edit the classes 'note' and 'footnote' in style.css to change the font size and style of these items.

GenoPro Support (8/31/2005)
I modified the code so all notes are displayed by default

Some of us use notes to hold a whole load of background information that can detract from the appearance and readability of a page. This is why notes were hidden by default. I think another option parameter is required to control this. It will become easier to select from the available options once the 'paramaters' tab is added to the 'Generate Report' window in GenoPro. (I hope this is still on the list of improvements)

By beraha - Wednesday, August 31, 2005
Ron (8/31/2005)
beraha (8/31/2005)
Do you have any solution to the problem where the picture is somtimes cut?

Please see my earlier post in this thread.

 

I saw your solution before sending my last post. I tried to make those modofocation but it didn't work. I'll try again. Smile

 

edit !!!!

Thank you - It works now

By GenoProSupport - Wednesday, August 31, 2005
Ron
GenoPro Support
I modified the code so all notes are displayed by default

I think another option parameter is required to control this.

This is a good suggestion to let the user decides if he/she wants the annotations be visible by default.  I am thinking of re-writing the JavaScript code responsible for expanding and collapsing nodes.  The script does the work fine however suffers performance problems with several thousand nodes.  When I generated a report with 85,000 individuals, the file toc_tree.htm (similar to http://morinfamilytree.genopro.com/toc_tree.htm) took over 5 minutes to expand.  I am confident I can cut down the time to less 5 seconds by optimizing the code.  This task is not a priority however.

It will become easier to select from the available options once the 'paramaters' tab is added to the 'Generate Report' window in GenoPro. (I hope this is still on the list of improvements)

Yes, it is still on the menu.  I need to prioritize tasks.

By maru-san - Wednesday, August 31, 2005
MR (8/31/2005)
Reloaded Beta 14. Just to be sure -picture comments and the buttons for wife/husband of an individual are still given vertically, each line contains just one word or symbol.


Have not seen any answer yet to above, which is not only true for the individual, but also to the family page.
By GenoProSupport - Wednesday, August 31, 2005
Have not seen any answer yet to above, which is not only true for the individual, but also to the family page.

I would think both. If anyone knows how to fix it, please let me know.

By Anna - Wednesday, August 31, 2005
Error in main home page link:

The "startup" page of the report will not display, neither immediately upon opening the report, nor by clicking the home icon.

Anna

By MR - Wednesday, August 31, 2005
The above is true in Mozilla. With IE it works perfect.
By Howard53 - Wednesday, August 31, 2005
I wrote earlier:

Howard53 (8/31/2005)
The marriages can be reported in the wrong order when no date information exists. It is fairly common not to have date information, and could be overcome by the use of a Marriage Number Tag under Family Properties as with Child Number under Individual Properties (this may have been suggested previously).

At the time I couldn't find the relevant topic - I now have and have posted a reply in the topic for describing the Child Number / Pedigree Link Number / Relation number.

By beraha - Thursday, September 1, 2005
On occupation properties, when I want to add details about the place where I work NOW, I leave the "End Date" field empty. But - the report generator, still use the word: "WAS" instead of "is".

"From 1997 his occupation was ...."

instead of:

"From 1997 his occupation is ..."
 

By GenoProSupport - Thursday, September 1, 2005
I think the occupation record should have a property flag StillActive to indicate if the individual is still having this occupation.  Leaving the "End Date" blank could work, but it is not as accurate as someone may know the occupation start date but not the end date.
By beraha - Thursday, September 1, 2005
GenoProSupport (9/1/2005)
I think the occupation record should have a property flag StillActive to indicate if the individual is still having this occupation.  .

Is it a complicated task for version 3 Sad or an easy one for the next Beat14b? Tongue:

By GenoProSupport - Thursday, September 1, 2005
beraha (9/1/2005)
Is it a complicated task for version 3 Sad or an easy one for the next Beta14b? Tongue:

It is just a checkbox (very easy) and I can add it for Beta14b.  However I want to do a good job here, and I am thinking to have a combo named "Occupation Termination" with choices such as "Still Working", "End of Contract", "Quit Job", "Fired", "Retirement".

By Barry Graham - Friday, September 2, 2005
Dan said:-
I would think both. If anyone knows how to fix it, please let me know.


What would happen if ALL photos were left justified.
I can't test this but problem seems to lie in trying to force the photos to the right of text.
By maru-san - Friday, September 2, 2005
GenoProSupport (8/31/2005)
Have not seen any answer yet to above, which is not only true for the individual, but also to the family page.


I would think both. If anyone knows how to fix it, please let me know.


Have moved line "WriteHtmlAnnotationPicture Dic("Family"), f" behind the marriage notes in the file Lang.vbs.

It works for me without the notes on the picture.
By genome - Saturday, September 3, 2005
GenoProSupport (8/31/2005)
Have not seen any answer yet to above, which is not only true for the individual, but also to the family page.

I would think both. If anyone knows how to fix it, please let me know.

Have now got some amended routines ready. The above problem is fixed and there are options for

  1. Whether Notes are initially expanded or not.
  2. Whether or not family details are shown on individuals page
  3. whether or not picture titles/names are shown below pictures

Amended versions of Config.xml, individual.htm, family.htm, code\util.vbs & code\lang.vbs are attached. Right click on each file and download (save target as..) to appropriate folder Please rename .txt files to .vbs during downloading (to Code folder) as this forum doesn't allow .vbs file attachments and also doesn't seem to like some zip files!

I'll have a look at some of the grammatical issues. e.g. if there is a single granparent it should say 'grandfather was' or 'grandmother was' not grandparents were.  etc.

By IainTait - Saturday, September 3, 2005
Ron, Thanks for coming to the rescue as usual with your fixes.

Unfortunately your zip won't open whether downloaded or not as it seems to have got corrupted in uploading.Blink

By genome - Saturday, September 3, 2005
Have edited my post to attach plain files. The original zip file uploaded as 14.4 Kb but downloaded as 13.9 kb and winzip thinks it is corrupt.  ???
By gorbav - Saturday, September 3, 2005
I had no problem with the zip-file.
Should lang.txt and util.txt be renamed to lang.vbs and util.vbs and put in the skins/english/code directory?
By IainTait - Saturday, September 3, 2005

Thanks Ron for the files which I downloaded without problems.

I copied them to my skin from Beta14, but got the error  below when trying to generate the report.

I seem to remember that this had happened before with one of the earlier versions. All photos seem to be there in the gno.

 Error at line 38 (individual.htm) generating 'ind00033.htm': Nombre d'arguments ou affectation de propriété incorrects: 'WriteHtmlAnnotationPicture'

Erreur d'exécution Microsoft VBScript 800A01C2

By maru-san - Saturday, September 3, 2005
Although I had solved my problem on the family page I have downloaded ron's files and tried them. The individual page page has improved, however the family page needs to be reviewed again, since the picture of the child/children is now underneath of each narrative text, not next to eachother.

Besides in Dan's report generator and also in ron's last report #7, the picture name (file name) underneath of the picture was not shown, now it shows up again. I will have to work hard to remove it again. In the config file it is asking to hide or show the name, but even with "N" it shows up.

Thats it so far and I really hope that the creators of the report generator will improve what they have started, which is very!! promising. My german translation is almost finished, started now to work on the japanese, but this will take more time, since prepositions are behind places and time.
By genome - Sunday, September 4, 2005
Sorry Maru-San, I have corrected an error in individual.htm that caused pictures names to stay even if config.xml said no. New file attached here and in original post. However I can't reproduce the problem you have with child pictures and associated narrative.

Iain, are you sure you have copied lang.vbs and util.vbs to the Code folder below your template folder as per instructions? It would appear you are using the orginal util.vbs.

By IainTait - Sunday, September 4, 2005

Thanks Ron,

Of course I had left the two files as text in the main folder! Blush I have corrected this.

I also downloaded your new individual.htm, but when I made the report I got this error message :-

   Unable to find "PhBurial" in language dictionary!

Any ideas why?

I also noticed that on the family page, the parents names are there , but not linked to their respective pages and nor are there photos of them at all.

Aleast like this there is no problem with vertical photo scrolling controls!

Do you remember how the old report every "individual page" had plain "Name Links (with no details)" on it to immediate family pages and to the spouses and the "Family page", which itself had plain "Name Links" back to the various "individual pages" including the grandparents, spouses and children of the Children (ie the family pages included all the family members with photos and details, plus the links to grandparents and grandchildren.)

With all these super new fields, the original layout seems to have been confused, which I think is a shame as it worked very well except for the lack of fields.

The header is a good idea and all the other future index pages as well, it is just the relationship between the individual and family pages and their content which seem to cause a little confusion.

The old report with the place names would have done me fine, but now, having seen all the new possibilities of Beta14, things are getting very complicated! Ermm

 

By GenoProSupport - Sunday, September 4, 2005
iaintait (9/4/2005)
   Unable to find "PhBurial" in language dictionary!

The phrase PhBuried got renamed to PhBurial.  You probably have an old file Lang.vbs with a new Dictionary.xml.

By IainTait - Sunday, September 4, 2005
Thanks Dan,

It was the other way round in fact, as the "lang.vbs" downloaded from Ron needed changing as it had phBuried instead of phBurial, and the Dictionary.xml was from your Beta14.

It worked OK after this.

There is still the question of links and layout for the individual and family pages.

In my opinion, your layout for the "individual.htm" would be better for the "family.htm" as I would like to see the Parents on this page as well as the children. 

The "individual.htm" could be more like the one Ron has done without spouse or children just links to them and the family.htm as this will avoid duplication on the individual pages as I had mentioned before for the earlier contributions from Ron before the Beta14.

By maru-san - Sunday, September 4, 2005
Ron (9/4/2005)
However I can't reproduce the problem you have with child pictures and associated narrative.


Actually it is not a bug but something wich will happen on your family page, depending on how much information you have. And it happens only to the first child. So if you have a family, you show the text to the left, to the right you show the couple's picture (name is still showing), below the text the family comments and below this the child's text, below that the picture of that child. The next child shows the picture to the left and the text to the right next to the picture.

Layout in IE is ok, in Mozilla not. Something to be done. (tried with 14b)