GenoPro Home  |  Get Started With My Genealogy Tree  |  Buy  |  Login  |  Privacy  |  Search  |  Site Map
 

GenoPro Support Forum




'Gamma' Report Generator bug: Display.Colors.Label.Fill.Top & .Bottom...

Click to view RSS...
Author If defaulted these fill colors are set to #FFFFFF (white) instead of null or the border background
Posted Sunday, October 24, 2010 - Post #26756
Legendary Master

Legendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary Master

Administrators
Customers
Important Contributors
FamilyTrees.GenoPro.com
GenoPro version: 2.5.4.1

Last Login: 10 minutes ago
Posts: 2,095, Visits: 13,843
GenoPro Monica (aka Gamma) currently outlines the text in the top and bottom labels of an Individual's genomap symbol.

The color used to outline the text can be set explicitly or left to 'auto'. On a genomap within GenoPro itself, if a border background color is set then the label fill/outline 'auto' setting uses the same color as the border background. 

However the Report Generator sets the label fill colors (i.e. tags Display.Colors.Label.Fill.Top and Display.Colors.Label.Fill.Bottom) to FFFFFF (white) if set to 'auto'. Thus in a report skin it is not possible to tell whether the user intended an explicit 'white' fill or whether it should be defaulted to the background color.

I believe that when set to 'auto' these tags should either be set to null of the border background color.

http://support.genopro.com/Uploads/Images/e0d9be8b-5d38-46c0-8eed-328d.png



'lego audio video erro ergo disco' or "I read, I listen, I watch, I make mistakes, therefore I learn"


Edited: Sunday, October 24, 2010 by Ron
Posted Monday, October 25, 2010 - Post #26758
Forum Master

Forum MasterForum MasterForum MasterForum MasterForum MasterForum MasterForum MasterForum MasterForum Master

Gamma
Moderators
Administrators
FamilyTrees.GenoPro.com
Customers
GenoPro version: 2.5.4.1

Last Login: 2 minutes ago
Posts: 898, Visits: 9,779
The entire outline will be put back as a option disabled by default and review because it's cause many issues here and there.
Posted Tuesday, October 26, 2010 - Post #26766
Legendary Master

Legendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary Master

Administrators
Moderators
Translator
GenoPro version: 2.5.4.1

Last Login: Friday, December 12, 2014
Posts: 3,766, Visits: 18,817
I modified the code to import old .gno documents to adjust the colors.  It should be fine now.  Let me know if you see another problem with this.

Posted Thursday, October 28, 2010 - Post #26784
Legendary Master

Legendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary Master

Administrators
Customers
Important Contributors
FamilyTrees.GenoPro.com
GenoPro version: 2.5.4.1

Last Login: 10 minutes ago
Posts: 2,095, Visits: 13,843
There is no change in results with version 2.5.2.5

Note that the problem is not related to import of old versions of .gno files.

If I create a new .gno under 2.5.2.5 and create two individuals with border, one with the label fill defaulted and the other with it set explicitly to white

e.g.
http://support.genopro.com/Uploads/Images/f56021d1-178f-4e89-ba29-ee1d.png


and then run the Report Generator

e.g. with this skin template

<%[
for (var iCnt = 0; iCnt < Individuals.Count; iCnt++) {
        i = Individuals(iCnt);
        Report.LogComment(i.ID + ': '+i.Name +' Label.Fill.Bottom='+ i.Display.Colors.Label.Fill.Bottom);
}
Report.AbortReport();
]%>

Then I get the result:

ind00001: "bottom fill default" Label.Fill.Bottom=#FFFFFF
ind00002: "bottom fill white" Label.Fill.Bottom=#FFFFFF

I.e. from the Report Generator's view point, the formatting of the two individuals is the same with text outline set to white. However it is obvious from the picture of the genomap above that they are not the same because when the label fill color is defaulted then the border background color, yellow in this case, is used.

I repeat: if the label fill color is defaulted (i.e. shown as 'auto' in the Display tab of the Propertoes dialog, then the Report Generator should set the Display.Colors.Label.Fill.Bottom & Top to an empty string or null.





'lego audio video erro ergo disco' or "I read, I listen, I watch, I make mistakes, therefore I learn"
Posted Thursday, October 28, 2010 - Post #26785
Legendary Master

Legendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary Master

Administrators
Moderators
Translator
GenoPro version: 2.5.4.1

Last Login: Friday, December 12, 2014
Posts: 3,766, Visits: 18,817
I slightly modified the drawing logic for the text outline color of top and bottom labels.  In a nutshell, if the color is set to automatic, then the text outline color of labels uses the same color as the background of the individual.  On the other hand, if there is no background, then the text outline color is white.  I wanted to fix the problem where the "transparent text for labels" displaying text in an ugly way... I thought this was a good solution, however this change creates a bunch of other problems.

Do you have a better suggestion?



Edited: Thursday, October 28, 2010 by GenoProSupport
Posted Friday, October 29, 2010 - Post #26794
Legendary Master

Legendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary Master

Administrators
Customers
Important Contributors
FamilyTrees.GenoPro.com
GenoPro version: 2.5.4.1

Last Login: 10 minutes ago
Posts: 2,095, Visits: 13,843
GenoProSupport (10/28/2010)I slightly modified the drawing logic for text outline color of top and bottom labels. do you have a better suggestion?

I have no problem with the modified logic. I want to be able to use the same logic within the Narrative Report so as to achieve the same result. But my problem is that at present I cannot determine when the 'auto' rule is being applied because Report Generator api returns the wrong value for the property Display.Label.Fill.Top & Display.Label.Fill.Bottom. Instead of returning the expected emrty string or null it returns #FFFFFF. I need to be able to determine when the label fill has been set to 'auto' and so all I am asking is that you set the Fill values correctly.As an additional point that has been made elsewhere I would also like to have an option to use a text background as per 2.0.1.6 as well as the text outline method.



'lego audio video erro ergo disco' or "I read, I listen, I watch, I make mistakes, therefore I learn"
Posted Monday, November 01, 2010 - Post #26820
Legendary Master

Legendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary Master

Administrators
Moderators
Translator
GenoPro version: 2.5.4.1

Last Login: Friday, December 12, 2014
Posts: 3,766, Visits: 18,817
I have fixed the code to return the proper color for the report generator.  On my computer, the generated SVG displays the top & bottom labels fine without any modification to your report skin.  I still several little things to fix before uploading the update.



Edited: Thursday, November 11, 2010 by GenoProSupport
Posted Thursday, November 11, 2010 - Post #26885
Legendary Master

Legendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary Master

Administrators
Moderators
Translator
GenoPro version: 2.5.4.1

Last Login: Friday, December 12, 2014
Posts: 3,766, Visits: 18,817
The fix is available at http://www.genopro.com/monica/ .  I also wrote code t honor compatibility with previous versions to display individuals with the proper background color and date formats.



Similar Topics

Click to view RSS...
Expand / Collapse

Reading This Topic

Expand / Collapse