GenoPro Home
GenoPro Home  |  Get Started With My Genealogy Tree  |  Buy  |  Login  |  Privacy  |  Search  |  Site Map
 

GenoPro Support Forum




Feedback on the latest Narrative Report

Click to view RSS...
Author
Posted Monday, May 30, 2022 - Post #42221
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
Hi Ron,

I've been working my way through the latest narrative report, getting ready to publish my new family tree based on the latest skin. I've been hacking the skin a little (cough) to suit my own requirements and having lots of fun. (https://familytrees.genopro.com/HarryCaper/TheFamilyTree/)

I have a little feedback on the family maps (the family_map-famXXXXX.htm). I think this needs a tweak as the map doesn't load. I assumed I'd broken it with my code changes, but I've checked using a vanilla (unaltered) version of the skin, with the same result.

I've just done a quick compare between a individual_map-indxxxxxx.htm and a family_map-famXXXXX.htm - they're calling different .js scripts, and have slight code differences, perhaps a left over from the switch from google maps. See below.

I'm going update the initiating family_map.htm file in my custom skin, but thought I'd better let you know so it can be fixed for general release.

I have one or two other tweaks I've made to my custom skin which I'll post about on this thread, as they might be useful for the next release.

From the individual_map-indxxxxxx.htm :


<script src="scripts/gmap_data.js" type="text/javascript"></script>

$(function () {
           PageInit(true);
           var loaded=true;
           showPopUpFrame();
           initLocationMap();
           window.addEventListener('resize',initLocationMap, false);
           setTimeout(function(){makeLocationMap(gMapData);},11);
        }
); 


From the family_map-famXXXXX.htm :

<script src="scripts/gmap_places.js" type="text/javascript"></script>

$(function () {
PageInit(true);
var loaded=true;
showPopUpFrame();
initLocationMap();
makeLocationMap(gMapData);
window.onresize=initLocationMap;
}
);
Posted Monday, May 30, 2022 - Post #42223
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
Another bit of feedback relates to the Source/Citation section.

I use the "Put Source/Citation references in collapse/expand section" option, and I noticed that from an individual and from a family page - when you click on a citation it doesn't target the popup frame (the popup is the targeted frame when clicking on citations elsewhere in the report).

I believe a tweak is needed to the sub WriteHtmlAllFootnotes in Utils.vbs

In my testing to resolve this I changed this line (line 1891):

                  Report.WriteFormattedBr "<sup><a name='{0}'></a>{0} </sup> <a href='source-{&t}.htm' {}><i>{}</i></a>", iFootnote, oFootnote.ID, strTitle, JoinSourceCitationNames(oFootnote, StrFormatText(oFootnote, StrParseText(oFootnote.title, True),False), True)


To this:

                  Report.WriteFormattedBr "<sup><a name='{0}'></a>{0} </sup> <a href='source-{&t}.htm?popup'  onclick='showPopUpFrame("""");' target='popup' {}><i>{}</i></a>", iFootnote, oFootnote.ID, strTitle, JoinSourceCitationNames(oFootnote, StrFormatText(oFootnote, StrParseText(oFootnote.title, True),False), True)


I also changed this line (line 1903) :

Report.WriteFormatted strSep & " <a href='source-{&t}.htm' {}><i>{}</i></a>", oFootnote.ID, strTitle, JoinSourceCitationNames(oFootnote, StrFormatText(oFootnote, StrParseText(oFootnote.title, True), False), true)


To this:

Report.WriteFormatted strSep & " <a href='source-{&t}.htm?popup'  onclick='showPopUpFrame("""");' target='popup' {}><i>{}</i></a>", oFootnote.ID, strTitle, JoinSourceCitationNames(oFootnote, StrFormatText(oFootnote, StrParseText(oFootnote.title, True), False), true)


best regards,
H
Posted Tuesday, May 31, 2022 - Post #42225
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
I also noticed that the HTML code I'd used in my Document description, which is used on the home.htm, wasn't being interpreted as HTML on report generation.

I resolved this by changing the generating home.htm on line 64 from :

@[ Report.Write StrFormatText(Null, doc.Description, False) ]@


To :

@[ Report.Write StrFormatText(Null, doc.Description, True) ]@


best regards,
H
Posted Tuesday, May 31, 2022 - Post #42226
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
This one is a suggestion for the fancybox gallery, which is to display the title of the picture as a caption when the picture is viewed through the fancybox.

Util.vbs line 2419 changes from:

            Report.WriteFormattedLn "<a class='gallery' data-fancybox='{5}' href='{2}' title='{4&t}'><img src='{0}'{1} alt='{3&t}' title='{3&t}'/></a>", strThumbnail, strAttributesHTML, strPath, Util.FormatPhrase(Dic("PhPictureTooltip"), "", p.Date.ToStringNarrative, p.Place.Session("Locative"), StrParseText(p.Source, True)), p, obj.id


to

            Report.WriteFormattedLn "<a class='gallery' data-fancybox='{5}' href='{2}' title='{4&t}' data-caption='{4&t}'><img src='{0}'{1} alt='{3&t}' title='{4&t}'/></a>", strThumbnail, strAttributesHTML, strPath, Util.FormatPhrase(Dic("PhPictureTooltip"), "", p.Date.ToStringNarrative, p.Place.Session("Locative"), StrParseText(p.Source, True)), p, obj.id


When I was googling around, I found there is a newer version of fancybox which has a carousel feature, which looks very exciting. Well beyond my coding abilities to implement however. 

Posted Tuesday, May 31, 2022 - Post #42227
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
I've just noticed that in place-placeNNNNNN.htm, for places with a picture (and I think this is true also of source-sourceNNNNN.htm files too)- clicking the picture doesn't start the fancybox. See screenshots

Not sure if this is by design. 

http://support.genopro.com/Uploads/Images/a8e72165-499b-4b25-a9a4-dc79.jpg

http://support.genopro.com/Uploads/Images/47bed5d1-2d11-433f-9f0d-0c4f.jpg

I haven't looked into fixes for this - just spotted it.

all the best,
H.
Posted Tuesday, May 31, 2022 - Post #42228
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
On a related note, on my customised version of the narrative skin, I borrowed your code to put a picture icon next to places that have picture(s).

If you'd like to review those mods for possible inclusion into the base skin - let me know and I'll post them up.

I've done this for the Place TOC (the other TOCs look to already have this feature) and in the individual.htm

With my trees I've never added pictures to occupancies - I've always added them to places, which is why I made this mod.

I've only just found out during testing today that small photos are displayed in the report for occupancies, but from a layout perspective I prefer the picture icon rather than a small picture, so it turned out to be happy error on my part that I associated the pictures with the places.

http://support.genopro.com/Uploads/Images/af536075-0201-422c-9775-b03f.jpg




http://support.genopro.com/Uploads/Images/78e1f5da-919d-43c2-8d37-4b85.jpg


that's all from me, finally,
H.
Posted Tuesday, May 31, 2022 - Post #42229
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
Sorry one more glitch... I've no idea what is causing this, but it seems repeatable.

This is to do with maps for individual places generated by gmap_place.htm

If I start from one of my individuals, and click on a place link in the Whereabouts section it pops up the place-placeNNNNN.htm - if I use the map icon from the pop up for that place - the map only loads about the top third of the tiles, the rest are grey.

http://support.genopro.com/Uploads/Images/012ae562-5c84-486d-8d7b-6ffa.jpg


http://support.genopro.com/Uploads/Images/447a9ee0-a391-41f4-923b-520e.jpg




Strangely, if I start from the Places TOC, and choose the same place, and then click on the map icon for that place from places.htm - the map loads fine



http://support.genopro.com/Uploads/Images/54e68afb-5753-4102-b721-fc5a.jpg




http://support.genopro.com/Uploads/Images/e5ebf06f-7e29-4c7d-9b3f-5c23.jpg

bit of a puzzler,
H.

Edited: Tuesday, May 31, 2022 by HarryCaper
Posted Tuesday, May 31, 2022 - Post #42230
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
In penance for posting so much today, I hope this will be useful...

I've taken another look at the curvycorner solution - since we introduced this the functionality is built into css, and with the death of IE, I think we can use the css solution now. 

Ironically, since 2012 when we introduced this, curvy corners have gone out of fashion thanks to Windows 10. This new css solution makes it possible for folks to remove the curvy corners using the theme.css, and since the new solution doesn't use images - it makes customising the colour scheme easier too, as it doesn't use the corner images so these no longer need editing.

I've attached a zip of the amended skin. Every change I've made is notated with HarryCaper and the original code is still there commented out for easy comparison, although you probably have something like winmerge for doing comparisons. The image below shows the files that have been amended.

The changes made to the OliveBranch theme.css would need to be replicated in the other themes.

When you look at the changes, you'll notice I've also made some changes to things like padding and margins, and heights & widths for TOCs and Maps, and I've made use of the class cage on more pages (for padding to bring the text in from the edges). This is to address a couple of layout idiosyncrasies. 



http://support.genopro.com/Uploads/Images/37ab8fb3-1231-45b0-aed9-d68d.jpg


cheers,
H.
Posted Tuesday, May 31, 2022 - Post #42231
Forum Guru

Forum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum GuruForum Guru

FamilyTrees.GenoPro.com
Customers
GenoPro version: 3.1.0.1

Last Login: Thursday, June 2, 2022
Posts: 108, Visits: 1,280
... the attachment seems to be missing from my last post, trying again...

edit... I'm getting slightly different results publishing to my local drive than to the web with respect to the height of the TOCs and the maps. Looks perfect when running from my local drive, but the bottom of the TOC box & map box is off the screen when looking at the version published on the internet. 

No idea why that is - I ran the generator for the two locations back to back without making any changes. 

May need to shave another few px off the height of these which is set from script.js (line 1254) and tocstart.js (line 17). I have to confess I don't really understand the intricacies...

Skins2022.03.07.hc_corners.zip (49 views, 6.71 MB)

Edited: Tuesday, May 31, 2022 by HarryCaper
Posted Wednesday, June 1, 2022 - Post #42234
Legendary Master

Legendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary MasterLegendary Master

Administrators
Customers
Important Contributors
FamilyTrees.GenoPro.com
GenoPro version: 3.1.0.1

Last Login: Yesterday @ 11:34 PM
Posts: 3,174, Visits: 23,399
Wow! you have certainly been busy w00t  It's gonna take me a while to digest all of your posts, but many thanks for all your work on this.

One I can answer immediately is the question of HTML in the Document Description. You just need to prefix your text with the 'Custom Markup'  <?html?>. This can be used on anytext field.   See also 'How to customise your report' 

I'll look into the rest as soon as I can Wink


'lego audio video erro ergo disco' or "I read, I listen, I watch, I make mistakes, therefore I learn"


Similar Topics

Click to view RSS...
Expand / Collapse

Reading This Topic

Expand / Collapse