|
|
Administrators Customers Important Contributors FamilyTrees.GenoPro.com GenoPro version: 3.1.0.1
Last Login: Yesterday @ 10:10 PM
Posts: 3,428,
Visits: 26,569
|
At last, later than the two or three days I last indicated I have made a futher update to the skins in the 1st post of this thread. I discovered that the change history mechanism, i.e. using XML comments giving version details, was not compatible with the working of GenoPro's phrase editor. I have therefore ameded this to use additional 'V' (version) attributes to indicate changes. See head of Dictionary.xml for further information. I have also changed the Config Param Dialogue so that each section is initially collapsed to make navigation easier. Family relationship phrases now take better account of single parent families. So if only one parent is defined then there is no mention of husband/wife/partner or <Unknown> and phrases take the singular form. Finally, as well as a few bug clearances, I have added, as a result of a suggestion from JCG, a 'random phrase' facility that can be used to break up the monotony of repeated phrases. This involves having an 'X' attribute on selected phrases, indicating the number of eXtra variants of the phrase that are present. The additional phrase variants have the same key but with a _Xn suffix. The only example in the Dictionary at present is PhFR_LoveAffair, that has a X="1" attribute and an associated variant PhFR_LoveAffair_X1. You can of course add more of your own in a custom skin. Suggestions for more more variations welcome! This has only been implemened for the Narrative Report.
'lego audio video erro ergo disco' or "I read, I listen, I watch, I make mistakes, therefore I learn"
|
|
|
Important Contributors FamilyTrees.GenoPro.com Customers Translator GenoPro version: 2.0.1.6
Last Login: Tuesday, December 16, 2008
Posts: 390,
Visits: 1,271
|
Ron, A few obs regarding the Nar Rep: 1) <IrfanViewPath> and <InkscapePath> params in Config: Isn't it better to provide drive 'C' instead of drive '?' ? 2) for a couple with an unknown partner and no input in the Relation field:
Similar Nars are also produced with some Cohab inputs. Perhaps the title 'Partner' could be capitalized? 3) Dic PhFR/Txt Phs: Now that you introduced single parent, I need for my FR Rep a Gender ID param for the single parent. 4) I don't remember if it has already been mentioned but with Vista and Moz FF, the PDFs don't show up. Any settings you're aware of within FF? That's all for now. Your Random Nar Variant Phs routine works fine. Thank you Ron, JC Update for 4) : It's now OK. I right clicked one of my PDF file and opened it with FF. The file opened fine so the Report PDFs afterwards. Must have triggered an add-in! Update2: 5) Single parent: Should, in this case, 'They' be replaced by 'He'?
Edited: Sunday, August 31, 2008 by
jcguasp
|
|
|
Important Contributors FamilyTrees.GenoPro.com Customers Translator GenoPro version: 2.0.1.6
Last Login: Tuesday, December 16, 2008
Posts: 390,
Visits: 1,271
|
Ron, Trying to generate a Descendants Rep but param {7} is apparently not passed to some of the <PhFRTxt_...> phrases:
Descendants.js lines 329/340 Thanks Ron, JC
|
|
|
Important Contributors FamilyTrees.GenoPro.com Customers Translator GenoPro version: 2.0.1.6
Last Login: Tuesday, December 16, 2008
Posts: 390,
Visits: 1,271
|
Ron, Another few obs regarding the Descendants Report. Far from having checked all options!: A) EN Report: A.1) when a relation has only been selected, the Nar says nothing. It applies to Cohab and perhaps other options. On the other hand, a relation of Mariage (or divorce) come up OK (green arrow):
Another example, probably related: - The tree: 
- The Nar (absence of the Cohab with André Loison): 
... but appears in the name Index: 
A.2) PhBurial: 
A.3) Sources: - the multi-lang Brief Description field has not been processed (checked as processed OK in the main Nar Rep). - Perhaps 'The citation ...' Ph should start on a new line? 
A.4) when a Family has initially been selected, the 1st heading No doesn't seem complete, i.e. '.1.' should be '1.1.' 
... and when a Descendant type Rep has been selected, '.1.' should be '0.1.'. A.5) I set a Max. Generations of 3 and the kids associated with the 4th gene are listed OK but their superscript Nos should not be shown, as no Nar 4.xx. This comment also apply for the Name Index. B) FR Report specific: B.1) PossessiveProperNoun The Nar should say d' instead of de, according to the Dic template: 

Thank you Ron, JC Update: A.6) <PhFRTxt_CohabitationAndSeparation> in Dic: If not mistaken, the beginning of the Ph is missing: T="[{4} ]{0}..." Update 2: A.7) On the Config param panel, the tooltip associated with 'Family or Descendant style report' doesn't come up. On my FR Rep Config panel, the tooltip is truncated at the 1st apostrophe location. So problem with Html encoding? A.8) the button "Ok" should all be capitalized "OK" to match system buttons. A.9) I noticed some differences in line spacing (it's with OO as MS Word's not installed). The normal spacing on my screen is apparently about this one: 
... and here are some samples of bigger spacing, depending on the narrated Ph: 


The later, when showing a baptism Ph, is missing the end dot.
Edited: Friday, September 19, 2008 by
jcguasp
|
|
|
Administrators Customers Important Contributors FamilyTrees.GenoPro.com GenoPro version: 3.1.0.1
Last Login: Yesterday @ 10:10 PM
Posts: 3,428,
Visits: 26,569
|
Thanks yet again JC with your help. I believe I have managed to clear up most if not all your points. So starting at the beginning:1) the '?' in IrfanViewPath & InkscapePath is converted by the script into the drive letter on which Windows is installed. I occasionally install Windows on D: and have seen H; used as well. So the default should work most of the time. 2) This is now fixed. However I also decided to remove the Family Relation phrase if nothing had been selected for it. (i.e. only report on data present, no comment if not). However I just realsed I need to change this again for the Descendants report 3) Added gender IDs for 1st family member {5} and partner/spouse {6}. 4) Thanks for the update on this - I tried it and had the same problem. I also have a problem with IE on Vista in that Acrobat Reader always launches in its own window. If nyone can fix this please let me know. 5) Fixed. Missing {7} in Descendants PhFR phrases. Yep, must have just tested these with Phase Editor and forgot to test the actual report! A.1) Seems OK now. Was probably due to missing {7} A.2) - A.8) Fixed. With A.7, for some reason Util.HtmlEncode does not appear to encode apostrophe to ' so added an explicit replace. A.9) Can't seem to reproduce this so a test .gno would help. Also still need to add that missing full stop. B.1) Added possessive name params to HeadingDescendants {2} and FamilyChildren {3} phrases in Dict so yo can use these instead. Also changed {0} in the FamilyChildren to be gender ID of a single child so phrase can say son or daughter instead of child.
'lego audio video erro ergo disco' or "I read, I listen, I watch, I make mistakes, therefore I learn"
|
|
|
Customers FamilyTrees.GenoPro.com Translator GenoPro version: 3.1.0.1
Last Login: Thursday, March 6, 2025
Posts: 84,
Visits: 288
|
To clarify: In the two downloads, is there a reason why the dictionary isn't the same version? (Time when saved differs)
|
|
|
Administrators Moderators Customers Gamma FamilyTrees.GenoPro.com Translator GenoPro version: 3.1.0.1
Last Login: Monday, June 2, 2025
Posts: 4,886,
Visits: 22,796
|
Ron (8/31/2008) A.2) - A.8) Fixed. With A.7, for some reason Util.HtmlEncode does not appear to encode apostrophe to ' so added an explicit replace.This is strange. I checked the source code and the apostrophe are encoded as ' (because the entity ' does not work in IE). Please notice the round apostrophe is not encoded however. Again, I could be wrong on this, however the routine Util.HtmlEncode should take care of the apostrophe (which is visually the same as the single quote).
Edited: Tuesday, September 2, 2008 by
GenoProSupport
|
|
|
Administrators Customers Important Contributors FamilyTrees.GenoPro.com GenoPro version: 3.1.0.1
Last Login: Yesterday @ 10:10 PM
Posts: 3,428,
Visits: 26,569
|
Anna (9/2/2008) To clarify: In the two downloads, is there a reason why the dictionary isn't the same version? (Time when saved differs)
Yep, a very valid reason - ageing brain cells! I simply forgot to run the WinMerge check I normally do. Now corrected.
'lego audio video erro ergo disco' or "I read, I listen, I watch, I make mistakes, therefore I learn"
|
|
|
Administrators Customers Important Contributors FamilyTrees.GenoPro.com GenoPro version: 3.1.0.1
Last Login: Yesterday @ 10:10 PM
Posts: 3,428,
Visits: 26,569
|
GenoProSupport (9/2/2008)
Ron (8/31/2008) A.2) - A.8) Fixed. With A.7, for some reason Util.HtmlEncode does not appear to encode apostrophe to ' so added an explicit replace. This is strange. I checked the source code and the apostrophe are encoded as ' (because the entity ' does not work in IE). Please notice the round apostrophe is not encoded however. Again, I could be wrong on this, however the routine Util.HtmlEncode should take care of the apostrophe (which is visually the same as the single quote). It is indeed very strange. I added a diagnostic line above line 117 in Code\IEForm.js of Descendants Report this.Cell = function(oParent, sWidth, sAlign, sTip) { if (sTip) Report.LogComment(sTip + ''+Util.HtmlEncode(sTip)+''+Util.HtmlEncode(sTip).replace(/'/g,"'") ); var oNode, sTitle = (sTip ? " title=\'" + Util.HtmlEncode(sTip).replace(/'/g,"'") + "\'" : ""); oNode = oIEdoc.createElement("<td style='width: " + sWidth + "; text-align: " + sAlign + ";'" + sTitle + ">"); return oParent.appendChild(oNode); }
| and I got Loading Dictionary.xml... [0.00] Processing template 'Main.js'... To disable display of parameter settings, tick the box under 'Options' tab of 'Generate Report' dialog. 'Family' report has initial family as 'First Generation'. 'Descendant' report has children as first generation. 'Family' report has initial family as 'First Generation'. 'Descendant' report has children as first generation. 'Family' report has initial family as 'First Generation'. 'Descendant' report has children as first generation
I.e. Util.HtmlEncode on its own did nothing but adding .replace(/'/g, "'") fixes it. Yet other tests show HtmlEncode working correctly
'lego audio video erro ergo disco' or "I read, I listen, I watch, I make mistakes, therefore I learn"
|
|
|
Administrators Moderators Customers Gamma FamilyTrees.GenoPro.com Translator GenoPro version: 3.1.0.1
Last Login: Monday, June 2, 2025
Posts: 4,886,
Visits: 22,796
|
I discovered the problem: the routine Util.HtmlEncode() invokes a global routine similar as Report.WriteText() , thus performing the encoding according to the output format. Since the .js file is assumed to be text, then the routine Util.HtmlEncode() was performing a 'text encoding' instead of an 'html encoding'. The 'text coding' is trivial, and this is why the quotes (and other characters) were not encoded by Util.HtmlEncode() .In Config.xml <Report Template="Main.js" OutputFormat="Text"/> |
I have modified both routines Util.HtmlEncode() and Util.XmlEncode() to explicitly encode regardless of the output format. Let's see if the fix will give the desired result. The fix is available at http://www.genopro.com/download/InstallGenoPro.2.0.1.6.exe (notice this fix does not include the new updated skins).
Edited: Tuesday, September 2, 2008 by
GenoProSupport
|