|
|
|
|
Customers
Important Contributors
GenoPro version: 3.0.0.7
Last Login: Sunday, November 26, 2023
Posts: 213,
Visits: 4,464
|
GenoProSupport (9/18/2005)
Instead of editing the code, just download the attachment below. BRAVO !!!!!  It works great now. *** EDIT: NOT AVAILABLE ANYMORE *** I'm so happy I could assist you a little bit, and that you could fix this bug, so everyone could enjoy it. Well done. I'm impressed. You really are doing a great job. I'm sure all of the Beta testers think that way.
Edited: Wednesday, May 31, 2006 by
beraha
|
|
|
|
|
Administrators
Moderators
Customers
Gamma
FamilyTrees.GenoPro.com
Translator
GenoPro version: 3.1.0.1
Last Login: Tuesday, October 28, 2025
Posts: 4,886,
Visits: 22,799
|
I thought the HTML code was missing only the idPVd_fam00008, but it is also missing the idPVv_fam00008.The new code is as follows: var oVisibility = document.getElementById("idPVv_" + id);
if (oVisibility != null)
{
if (strDescription != "")
{
elementRemoveClass(oVisibility, "hide");
elementAddClass(oVisibility, "show");
}
else
{
elementRemoveClass(oVisibility, "show");
elementAddClass(oVisibility, "hide");
}
} |
Instead of editing the code, just download the attachment below.
script.js
(196 views,
19.40 KB)
|
|
|
|
|
Customers
Important Contributors
GenoPro version: 3.0.0.7
Last Login: Sunday, November 26, 2023
Posts: 213,
Visits: 4,464
|
GenoProSupport (9/18/2005)
The problem is for everyone generating reports with family pictures. I already made the fix for the next beta. I am waiting for your confirmation, just to make sure. I made those modification within the scripts.js and generated a report at: *** EDIT: NOT AVAILABLE ANYMORE *** The same problem  I also included now the "familytree.gno" for you to check the code
Edited: Wednesday, May 31, 2006 by
beraha
|
|
|
|
|
Administrators
Moderators
Customers
Gamma
FamilyTrees.GenoPro.com
Translator
GenoPro version: 3.1.0.1
Last Login: Tuesday, October 28, 2025
Posts: 4,886,
Visits: 22,799
|
beraha (9/18/2005)
Is this problem unique only to my tree or is it a general problem you should fix on the next beta? The problem is for everyone generating reports with family pictures. I already made the fix for the next beta. I am waiting for your confirmation, just to make sure.
|
|
|
|
|
Customers
Important Contributors
GenoPro version: 3.0.0.7
Last Login: Sunday, November 26, 2023
Posts: 213,
Visits: 4,464
|
I'll try to make those modifications and hope it will fix the problem.But - Let me understand. Is this problem unique only to my tree or is it a general problem you should fix on the next beta?
|
|
|
|
|
Administrators
Moderators
Customers
Gamma
FamilyTrees.GenoPro.com
Translator
GenoPro version: 3.1.0.1
Last Login: Tuesday, October 28, 2025
Posts: 4,886,
Visits: 22,799
|
The problem is the id of the picture's description is missing in the HTML. In other words, there should be an identifier idPVd_fam00008 in the HTML code so the picture slide show can update the picture's description as a new picture is being displayed. There is no such id because there because we don't want to display the picture description for this particular slide show.Solution: Edit the function PV_PickCore() in file scripts.js and replace the following line | document.getElementById("idPVd_" + id).innerHTML = strDescription; |
by var oDescription = document.getElementById("idPVd_" + id);
if (oDescription != null)
oDescription.innerHTML = strDescription; |
Edited: Saturday, September 17, 2005 by
GenoProSupport
|
|
|
|
|
Customers
Important Contributors
GenoPro version: 3.0.0.7
Last Login: Sunday, November 26, 2023
Posts: 213,
Visits: 4,464
|
GenoProSupport (9/18/2005)
I tested page *** EDIT: NOT AVAILABLE ANYMORE *** and noticed the error occurs when a picture contains the & symbol. Can you try renaming the picture name, file name and description to remove any &. Html uses the & as a reserved character and it is possible the report generator is not encoding this character properly. I did what you asked and removed all pictures contains the & symbol. Look at: *** EDIT: NOT AVAILABLE ANYMORE *** Still the same problem. What else should I remove?
Edited: Wednesday, May 31, 2006 by
beraha
|
|
|
|
|
Administrators
Moderators
Customers
Gamma
FamilyTrees.GenoPro.com
Translator
GenoPro version: 3.1.0.1
Last Login: Tuesday, October 28, 2025
Posts: 4,886,
Visits: 22,799
|
I tested page http://beraha3.atspace.com/test6/ind00001.htm and noticed the error occurs when a picture contains the & symbol. Can you try renaming the picture name, file name and description to remove any &. Html uses the & as a reserved character and it is possible the report generator is not encoding this character properly.I believe all & are being HTML-encoded as & but it is possible some of those characters slipped.
|
|
|
|
|
Customers
Important Contributors
GenoPro version: 3.0.0.7
Last Login: Sunday, November 26, 2023
Posts: 213,
Visits: 4,464
|
GenoProSupport (9/17/2005)
Can you try removing the picture comment מכתב אהבה מאליעזר לסטלה and re-generate the report. Maybe the JavaScript engine does not like Unicode text. If this is the problem, I can fix this easily. I have deleted all comments, and generated a shinked version of the tree using the original Skin *** EDIT: NOT AVAILABLE ANYMORE *** Still, the same problem, as you can see by yourself. So - I'm not sure the problem is with the Unicode text. I'm ready to generate more tests with less information as you like in order to find the problem.
Edited: Wednesday, May 31, 2006 by
beraha
|
|
|
|
|
Administrators
Moderators
Customers
Gamma
FamilyTrees.GenoPro.com
Translator
GenoPro version: 3.1.0.1
Last Login: Tuesday, October 28, 2025
Posts: 4,886,
Visits: 22,799
|
I get the JavaScript error Object Required running the picture slide show only in the page http://beraha.atspace.com/rivka/ind00024.htm.What is strange is the code works on http://beraha.atspace.com/rivka/family.fam00008.htm. I have extracted the code from http://beraha.atspace.com/rivka/ind00024.htm causing the error. When I compared this code with http://beraha.atspace.com/rivka/family.fam00008.htm, I found they are identical. I believe the problem lies in the following code: | <select class='hide' id='idPVs_fam00008' onchange="PV_PickCore('fam00008', 0);"> <option selected class='hide'
value='<img src='pictures/eliezerStela_levi4.jpg'
width='248' height='176' class='pic'
style='margin:36px 0px 36px 15px;'
onclick='viewPic(this.src)'
alt='eliezer&amp;stela_levi4'/>eliezer&stela_levi4' >
</option> <option class='hide'
value='<img src='pictures/eliezerStela_levi8.jpg'
width='188' height='248' class='pic'
style='margin:0px 30px 0px 45px;'
onclick='viewPic(this.src)'
alt='eliezer&amp;stela_levi8'/>eliezer&stela_levi8מכתב אהבה מאליעזר לסטלה' >
</option> <option class='hide'
value='<img src='pictures/eliezerStela_levi3.jpg'
width='168' height='248' class='pic'
style='margin:0px 40px 0px 55px;'
onclick='viewPic(this.src)'
alt='eliezer&amp;stela_levi3'/>eliezer&stela_levi3' >
</option> </select>
|
Can you try removing the picture comment מכתב אהבה מאליעזר לסטלה and re-generate the report. Maybe the JavaScript engine does not like Unicode text. If this is the problem, I can fix this easily.
Edited: Saturday, September 17, 2005 by
GenoProSupport
|